Try updating compats - Githubissues

SciML / EasyModelAnalysis.jl

High level functions for analyzing the output of simulations

MIT License

81 stars 14 forks source link

Try updating compats #250

Closed jClugstor closed 7 months ago

jClugstor commented 7 months ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

jClugstor commented 7 months ago

All tests except threshold should pass. Changes need to be made in some of the intervention functions. Things that are expecting scalars are getting vectors. In one of the tests, optimal_parameter_intervention_for_reach is trying to treat a tuple as callable.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.81%. Comparing base (c1a41ef) to head (5c5056d). Report is 4 commits behind head on main.

:exclamation: Current head 5c5056d differs from pull request most recent head e1c765e. Consider uploading reports for the commit e1c765e to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #250 +/- ## =========================================== - Coverage 92.02% 78.81% -13.22% =========================================== Files 7 7 Lines 439 439 =========================================== - Hits 404 346 -58 - Misses 35 93 +58 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jClugstor commented 7 months ago

This assumes that the cost function is intended to return a scalar, which should always be true as far as I know. The tuple stuff was because of a weird REPL state that I had where p was an array. Maybe if build_function ends up returning a tuple we should add an error message saying that the cost function should return a scalar?

There's still one more thing to fix in prob_violating_threshold, something to do with SciMLExpectations.

ChrisRackauckas commented 7 months ago

Is it not using the latest Integrals.jl?

jClugstor commented 7 months ago

My manifest says version = 4.4.1 which I believe is the latest.

jClugstor commented 7 months ago

I just needed to get rid of the batch = 0, so it defaults to batch = nothing which I think is in line with what was intended anyway.

jClugstor commented 7 months ago

Tests pass locally now. Looks like the tests for datafit passed, but there was an issue in code coverage, which caused the core tests to abort.