update to latest Turing.jl

SciML / EasyModelAnalysis.jl

High level functions for analyzing the output of simulations

MIT License

79 stars 13 forks source link

update to latest Turing.jl #259

Closed jClugstor closed 2 months ago

jClugstor commented 3 months ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Update Turing to fix compatibility issues.

jClugstor commented 3 months ago

Tests, pass, but CodeCov doesn't run. I think that's expected because of the CodeCov changes happening?

ChrisRackauckas commented 3 months ago

datafit tests don't pass?

jClugstor commented 3 months ago

I think they don't run if the Core tests don't completely pass. Since the codecov test didn't pass, the datafit tests never actually ran.

jClugstor commented 3 months ago

Should I just get rid of codecov in the CI?

ChrisRackauckas commented 3 months ago

It should already be disabled.

jClugstor commented 3 months ago

Ok so the datafit tests ran, but they took so long that it canceled out? Hmm...

ChrisRackauckas commented 3 months ago

Is someething like the iteration limit not being respected?

jClugstor commented 3 months ago

The tests are getting dt under epsilon and hitting maxiters now, which I can confirm doesn't happen with Turing 0.30. There was just a Turing patch, I'll try that.