search

SciML / FiniteStateProjection.jl

Finite State Projection algorithms for chemical reaction networks
MIT License
18 stars 7 forks source link

Update to Catalyst 13 and latest Symbolics #12

Closed isaacsas closed 9 months ago

isaacsas commented 9 months ago

This updates to the latest Catalyst (V13) and Symbolics. Please double check I understood what you wanted the Term in getsubstitutions to be -- Symbolics no longer uses Terms, and generally one shouldn't be directly constructing them or their new equivalent. It seemed like you wanted a vector of symbolic variables with a given symbol for their name, so that is what I replaced it with. I can update differently if needed.

Also, given Julia 1.6 is the latest LTS release I updated the Julia dependency to that. Most SciML packages only support 1.6 on now. (And will likely migrate up again soon if 1.10 or 1.11 becomes a LTS release.)

codecov-commenter commented 9 months ago

Welcome to Codecov :tada:

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

isaacsas commented 9 months ago

I missed the doc examples need updating too. Will try to do that today.

isaacsas commented 9 months ago

This should hopefully fix the doc builds. Note that Documenter.jl recently released a (breaking) 1.0 version, so I set this to the last pre-1.0 version. You'll need some more updates to migrate to 1.0.

kaandocal commented 9 months ago

Hi Sam, many thanks for your PR! I wanted to merge it yesterday but stumbled on the documentation bit. Merged!