Open pihop opened 2 years ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/jumps.jl | 9 | 11 | 81.82% | ||
<!-- | Total: | 66 | 68 | 97.06% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/aggregators/aggregated_api.jl | 4 | 77.27% | ||
src/jumps.jl | 10 | 84.39% | ||
<!-- | Total: | 14 | --> |
Totals | |
---|---|
Change from base Build 3856869287: | 1.5% |
Covered Lines: | 2165 |
Relevant Lines: | 2446 |
@pihop still taking a look over this -- I've been delayed by the US holiday and travel for it. One quick comment is it would be great if you could add a test that actually tests accuracy by comparing some statistic against simulations using the current approach.
@pihop looks like tests are passing now. Please let me know when you feel this is done and you have added an accuracy test that compares against the current solvers (to check you are getting the correct statistics on some simple example like A+B -> C). I'll then go through and give it a review. Thanks!!!
Looks like a real CI failure.
Extends the VariableRateJump interface to allow for user-defined bounds on time-dependent jump rates and look-ahead horizons for which the bound is valid. Implements a fictitious jump rejection algorithm based on https://journals.plos.org/ploscompbiol/article?id=10.1371/journal.pcbi.1004923.
Relevant issue: https://github.com/SciML/JumpProcesses.jl/issues/28