search

SciML / JumpProcesses.jl

Build and simulate jump equations like Gillespie simulations and jump diffusions with constant and state-dependent rates and mix with differential equations and scientific machine learning (SciML)
https://docs.sciml.ai/JumpProcesses/stable/
Other
140 stars 35 forks source link

Direct method allocations fix #307

Closed isaacsas closed 1 year ago

isaacsas commented 1 year ago

Closes https://github.com/SciML/JumpProcesses.jl/issues/305

@ChrisRackauckas could you look over the generated function I'm using. I'm always iffy on what is ok to do with them...

isaacsas commented 1 year ago

Also, some minimal benchmarking using the example in the makeprob function within the test gives that this is 3x faster than using FunctionWrappers on that system.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4548295710

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 4423865139: 0.4%
Covered Lines: 2112
Relevant Lines: 2391
💛 - Coveralls
isaacsas commented 1 year ago

@allocations is only 1.9 and up so that test won’t currently run in CI (but it runs fine locally). The remaining tests should cover that this hasn’t led to any correctness issues in Direct.