Added ExtendedJumpArray dispatch for ODE_DEFAULT_NORM

SciML / JumpProcesses.jl

Build and simulate jump equations like Gillespie simulations and jump diffusions with constant and state-dependent rates and mix with differential equations and scientific machine learning (SciML)

https://docs.sciml.ai/JumpProcesses/stable/

Other

135 stars 35 forks source link

Added ExtendedJumpArray dispatch for ODE_DEFAULT_NORM #334

Closed meson800 closed 11 months ago

meson800 commented 11 months ago

This change reduces the number of allocations (to zero!) required to take the norm of an ExtendedJumpArray. Previously, ODE_DEFAULT_NORM fell back to a default, allocating implementation.

I also added tests to check that this norm definition is equivalent to the old one, using (stable) random ExtendedJumpArrays. There's also a test that checks that the new norm dispatch is not allocating.

This should close SciML/DifferentialEquations.jl#969

isaacsas commented 11 months ago

Thanks @meson800! when you are done with updates could you run JuliaFormatter version 1.0.32 on the PR to pass the formatting check?

meson800 commented 11 months ago

Formatting and changes done, should be good to go! (but needs another CI run approval)

coveralls commented 11 months ago

Pull Request Test Coverage Report for Build 5604127673

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.009%) to 88.434%

Totals
Change from base Build 5588672874:	0.009%
Covered Lines:	2225
Relevant Lines:	2516

💛 - Coveralls

isaacsas commented 11 months ago

Thanks @meson800 for taking care of this!

isaacsas commented 11 months ago

9.7.2 with your fix should be out shortly.