search

SciML / JumpProcesses.jl

Build and simulate jump equations like Gillespie simulations and jump diffusions with constant and state-dependent rates and mix with differential equations and scientific machine learning (SciML)
https://docs.sciml.ai/JumpProcesses/stable/
Other
135 stars 35 forks source link

format attempt using JuliaFormatter master #362

Closed isaacsas closed 6 months ago

coveralls commented 8 months ago

Pull Request Test Coverage Report for Build 6683447053

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/aggregators/coevolve.jl 0 1 0.0%
src/spatial/spatial_massaction_jump.jl 3 4 75.0%
<!-- Total: 14 16 87.5% -->
Files with Coverage Reduction New Missed Lines %
ext/JumpProcessFastBroadcastExt.jl 1 50.0%
src/spatial/spatial_massaction_jump.jl 2 90.74%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 6290667336: 0.008%
Covered Lines: 2301
Relevant Lines: 2561
💛 - Coveralls
domluna commented 7 months ago

the fix was for the extra bracket indent

On Tue, Dec 12, 2023 at 11:27 PM Sam Isaacson @.***> wrote:

@.**** commented on this pull request.

In src/aggregators/coevolve.jl https://github.com/SciML/JumpProcesses.jl/pull/362#discussion_r1423991810 :

+function (p::CoevolveJumpAggregation{

  • T,
  • S,
  • F1,
  • F2,
  • })(integrator::AbstractSSAIntegrator) where
  • {T, S, F1, F2 <: Union{Tuple, Nothing}}

Using JuliaFormatter v1.0.45 I'm still getting a similar reformat to above: Screenshot.2023-12-12.at.8.25.52.AM.png (view on web) https://github.com/SciML/JumpProcesses.jl/assets/9385167/80af06b5-ed60-46e9-b0ec-48810e7d4cdc

— Reply to this email directly, view it on GitHub https://github.com/SciML/JumpProcesses.jl/pull/362#discussion_r1423991810, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAORUF5YX4X4XGWHNBAGZUDYJBLTRAVCNFSM6AAAAAA6U2IGIKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONZXGQ3DONRUGI . You are receiving this because you were mentioned.Message ID: @.***>