Closed isaacsas closed 6 months ago
Totals | |
---|---|
Change from base Build 7364429899: | 1.3% |
Covered Lines: | 2299 |
Relevant Lines: | 2556 |
For reference, not sure whether this is implemented or not, but I think the plan is to make something like;
@parameters k
...
prob.ps[k]
work for parameter indexing. Basically, due to parameters having some property, allowing
prob[k]
directly (like what is done for initial conditions) becomes type unstable. hence the indexing has to be done on the .ps
field instead. When it is clear that this is ready, we should move to that instead.
For reference, not sure whether this is implemented or not, but I think the plan is to make something like;
Set getp
/setp
.
But again this is separate from whether these tests should be here. The symbolic indexing interface has all of those things, but we are dropping specifically definition of names by defining f.syms
For some reason 1.10 CI seems bugged. Not sure why it is taking over an hour (I've already restarted it once).
OK, so we should just drop these tests completely then? Since otherwise there is no real way to create a problem with names here (i.e. we don't want to have to use MTK to run the tests...)
You can define a SymbolCache f.sys
You can define a SymbolCache
f.sys
Ok, that is very helpful to know. I was confused from looking at the example test file in SII and thought I’d have to completely build a custom struct satisfying the interface.
We'll make it a tutorial, https://docs.sciml.ai/SymbolicIndexingInterface/dev/simple_sii_sys/ it's just missing right now.
SciMLBase master supports prob.ps[p]
syntax now, so parameter indexing tests can use that instead
SciMLBase#master
isn't tagged yet, so this won't work
bump
Handled in https://github.com/SciML/JumpProcesses.jl/pull/408 now.
Since indexing problems by a parameter has been dropped by SciMLBase we shouldn't test for this anymore.