SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
245 stars 52 forks source link

Simple quick fix for refactor issue #207

Closed rayegun closed 1 year ago

rayegun commented 1 year ago

@ChrisRackauckas acceptable? I'll add a check option to UMFPACK for 1.9, and figure out how I want to do this in KLU. But this should suffice for now, we can always set check = false default later once those checks are integrated upstream.

codecov[bot] commented 1 year ago

Codecov Report

Merging #207 (b17f725) into main (8550cf9) will increase coverage by 0.22%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   64.00%   64.22%   +0.22%     
==========================================
  Files           9        9              
  Lines         625      629       +4     
==========================================
+ Hits          400      404       +4     
  Misses        225      225              
Impacted Files Coverage Δ
src/factorization.jl 80.00% <100.00%> (+0.39%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

rayegun commented 1 year ago

Okay I'm not sure I understand how switching a test from @test_throws to a legitimate test is decreasing tcov.

E: nevermind it had to update I guess

rayegun commented 1 year ago

What exactly do you want KLU and UMFPACK to do on a SingularException?

rayegun commented 1 year ago

Am I good to merge this, we can solve the SingularException question in a different PR?

ChrisRackauckas commented 1 year ago

Yes, I want to solve the other issue with retcodes, but we need enum retcodes first https://github.com/SciML/SciMLBase.jl/pull/274