SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

prototype reproducibility docs #214

Closed ArnoStrouwen closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #214 (18a881f) into main (6f3c63e) will decrease coverage by 4.09%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   63.80%   59.71%   -4.10%     
==========================================
  Files           9        9              
  Lines         630      628       -2     
==========================================
- Hits          402      375      -27     
- Misses        228      253      +25     
Impacted Files Coverage Δ
src/LinearSolve.jl 0.00% <0.00%> (-75.00%) :arrow_down:
src/default.jl 36.36% <0.00%> (-13.64%) :arrow_down:
src/common.jl 80.00% <0.00%> (-7.72%) :arrow_down:
src/factorization.jl 74.27% <0.00%> (-4.37%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 2 years ago

Is there any way we can give someone the manifest to download?

fredrikekre commented 2 years ago

Why not just commit docs/Manifest.toml?

ChrisRackauckas commented 2 years ago

Because then it doesn't update and it's not a good doc test.

ArnoStrouwen commented 2 years ago

If you don't want to commit the manifest, we can maybe copy it to assets in make.jl and then link it like: https://github.com/SciML/LinearSolve.jl/tree/gh-pages/v1.19.0/assets which will at least work for all the stable docs.

You can go further and for dev link things like: https://github.com/SciML/LinearSolve.jl/tree/ceafea5e1291d6902c781abf43bc877cd6c16d42/dev/assets

ChrisRackauckas commented 2 years ago

I think putting it in the assets is a nice idea.