search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

switch to `SciMLBase`s version of `_unwrap_val` #221

Closed oscardssmith closed 2 years ago

oscardssmith commented 2 years ago

part of the migration in https://github.com/SciML/NonlinearSolve.jl/pull/94 and https://github.com/SciML/OrdinaryDiffEq.jl/pull/1790.

codecov[bot] commented 2 years ago

Codecov Report

Merging #221 (c0fd71c) into main (6f3c63e) will increase coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   63.80%   63.85%   +0.04%     
==========================================
  Files           9        9              
  Lines         630      628       -2     
==========================================
- Hits          402      401       -1     
+ Misses        228      227       -1
Impacted Files Coverage Δ
src/LinearSolve.jl 75.00% <ø> (ø)
src/common.jl 89.09% <100.00%> (+1.37%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

devmotion commented 2 years ago

Maybe it would be less breaking to not change the type parameter but only change _unwrap_val and the constructor of OperatorAssumptions where it is used?

YingboMa commented 2 years ago

Ah, yeah, I guess we can always normalize OperatorAssumptions{nothing} to OperatorAssumptions{Nothing} in construction.

oscardssmith commented 2 years ago

Is that better? If so, I can switch it.

YingboMa commented 2 years ago

Yeah, then it won't be breaking at all.