search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
245 stars 52 forks source link

Error in KrylovKit? #227

Open rveltz opened 1 year ago

rveltz commented 1 year ago

Is it really intended?

https://github.com/SciML/LinearSolve.jl/blob/main/src/iterative_wrappers.jl#L294

I would expect

KrylovKitJL(KrylovAlg, gmres_restart, args, kwargs)
ChrisRackauckas commented 1 year ago

That looks like a typo. It would be good to fix it and add a test that hits it.

rveltz commented 1 year ago

Huuu

I thought it was simple but from codecov, KK is not tested :(

Ill try something