search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

Update sparspak #253

Closed j-fu closed 1 year ago

j-fu commented 1 year ago

In fact precompilation does not help much here - there are so many different generic FP types (and ForwardDiff breeds them in masses with diffent tags anyway) that probably a hint for users to care about precompilation themselves in the docs would make sense.

PetrKryslUCSD commented 1 year ago

This looks good. Agreed on the precompilation.

ChrisRackauckas commented 1 year ago

Precompiling for Float64, which is by far the most common case, is probably useful though.

codecov[bot] commented 1 year ago

Codecov Report

Merging #253 (bae7cc0) into main (e850e1e) will increase coverage by 0.31%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   65.99%   66.31%   +0.31%     
==========================================
  Files          12       12              
  Lines         744      754      +10     
==========================================
+ Hits          491      500       +9     
- Misses        253      254       +1
Impacted Files Coverage Δ
src/factorization.jl 78.60% <87.50%> (-0.98%) :arrow_down:
src/LinearSolve.jl 95.00% <100.00%> (+20.00%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 1 year ago

I'll run the formatter, thanks!