search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

Don't use qr! on SparseMatrixCSC #285

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

It's really slow, see https://github.com/SciML/LinearSolve.jl/issues/283

codecov[bot] commented 1 year ago

Codecov Report

Merging #285 (7cd2b00) into main (a5b11d7) will decrease coverage by 3.64%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   58.38%   54.74%   -3.64%     
==========================================
  Files          13       13              
  Lines         865      864       -1     
==========================================
- Hits          505      473      -32     
- Misses        360      391      +31
Impacted Files Coverage Δ
src/factorization.jl 64.72% <100.00%> (-5.93%) :arrow_down:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more