search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

Update documentation regarding alias behavior #309

Closed fredrikekre closed 1 year ago

fredrikekre commented 1 year ago

This patch documents that alias_A and alias_b may depend on whether the algorithm is known not to modify A or b. As a minimal first change, this patch updates the default value for alg::AbstractKrylovSubspaceMethod from false to true.

codecov[bot] commented 1 year ago

Codecov Report

Merging #309 (5f221eb) into main (9718ea2) will decrease coverage by 0.13%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   76.34%   76.21%   -0.13%     
==========================================
  Files          15       15              
  Lines        1209     1211       +2     
==========================================
  Hits          923      923              
- Misses        286      288       +2
Impacted Files Coverage Δ
src/common.jl 88.88% <0.00%> (-3.42%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

fredrikekre commented 1 year ago

What is the relation to the isinplace type parameter for LinearProblem? That one seems to be unused by this package.