search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
245 stars 52 forks source link

Re-enable some precompilation #316

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

Fix precompilation, requires the @generated function move until after the defaults are all defined. A bit ehh, but it works.

oscardssmith commented 1 year ago

IMO, LinearSolve probably shouldn't be doing precompilation. Other packages that have specific types of solves should do the precompilation instead. Since Julia 1.8, the precompilation workload doesn't have to be in the same package as the code, so putting lots of precompiles here isn't necessary.

ChrisRackauckas commented 1 year ago

But that duplicates precompilation. With such a quick precompilation, I don't see why it would be an issue.