search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
248 stars 53 forks source link

workaround Cholesky factorization limitations on v1.6 #321

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

It won't handle adjoint but that makes it error even when its not used from the default choice, and so this makes it so the defaults don't error. Past v1.7 it's not needed.

codecov[bot] commented 1 year ago

Codecov Report

Merging #321 (c35900c) into main (3f54753) will increase coverage by 8.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   66.77%   74.79%   +8.01%     
==========================================
  Files          17       17              
  Lines        1222     1218       -4     
==========================================
+ Hits          816      911      +95     
+ Misses        406      307      -99
Impacted Files Coverage Δ
src/factorization.jl 74.82% <100.00%> (+7.20%) :arrow_up:

... and 7 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more