search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
244 stars 52 forks source link

Set a sparsity threshold for KLU #343

Closed ChrisRackauckas closed 1 year ago

ChrisRackauckas commented 1 year ago

Closes https://github.com/SciML/LinearSolve.jl/issues/340. While many results are very much based on more details about the sparsity pattern, it's at least clear that if the matrix is not very sparse then it should probably use UMFPACK, so this is a conservative bound. When mixed with the length bound, I find that this seems to work rather well, though is not always optimal, is at least better than always choosing UMFPACK

ChrisRackauckas commented 1 year ago
Screenshot 2023-07-15 at 9 36 13 PM
codecov[bot] commented 1 year ago

Codecov Report

Merging #343 (ab17349) into main (61f4dc3) will increase coverage by 0.74%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   75.51%   76.26%   +0.74%     
==========================================
  Files          17       17              
  Lines        1266     1268       +2     
==========================================
+ Hits          956      967      +11     
+ Misses        310      301       -9
Impacted Files Coverage Δ
src/default.jl 67.08% <100.00%> (+1.06%) :arrow_up:

... and 4 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more