search

SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
244 stars 52 forks source link

Fix defaultalg method ambiguity for SciMLOp + GPUArray #385

Open vpuri3 opened 11 months ago

vpuri3 commented 11 months ago

should fix this error

Candidates:                                                                                                                                                        
  defaultalg(A::SciMLOperators.AbstractSciMLOperator, b, assump::LinearSolve.OperatorAssumptions)
    @ LinearSolve ~/.julia/packages/LinearSolve/Rq2MY/src/default.jl:132                                                                                           
  defaultalg(A, b::GPUArraysCore.AbstractGPUArray, assump::LinearSolve.OperatorAssumptions)                                   
    @ LinearSolve ~/.julia/packages/LinearSolve/Rq2MY/src/default.jl:106

Possible fix, define
  defaultalg(::SciMLOperators.AbstractSciMLOperator, ::GPUArraysCore.AbstractGPUArray, ::LinearSolve.OperatorAssumptions)
codecov[bot] commented 11 months ago

Codecov Report

Merging #385 (93a5dc2) into main (0f21a9d) will increase coverage by 0.19%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
+ Coverage   68.25%   68.45%   +0.19%     
==========================================
  Files          24       24              
  Lines        1884     1880       -4     
==========================================
+ Hits         1286     1287       +1     
+ Misses        598      593       -5
Files Coverage Δ
src/default.jl 65.18% <66.66%> (-0.20%) :arrow_down:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

ChrisRackauckas commented 11 months ago

add a test?