SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
244 stars 52 forks source link

[EnzymeExt] Prefix AbstractKrylovSubspaceMethod to avoid undefvarerror #402

Closed enigne closed 10 months ago

enigne commented 10 months ago

Fixes bug when using LinearSolve (cc @wsmoses)


ERROR: LoadError: UndefVarError: `AbstractKrylovSubspaceMethod` not defined
Stacktrace:
  [1] #reverse#22
    @ ~/.julia/packages/LinearSolve/sUzK0/ext/LinearSolveEnzymeExt.jl:147
  [2] reverse
    @ ~/.julia/packages/LinearSolve/sUzK0/ext/LinearSolveEnzymeExt.jl:132 [inlined]
  [3] #solve#83
    @ ./deprecated.jl:105
  [4] solve
    @ ./deprecated.jl:103
  [5] Solverx
    @ ~/Dartmouth/dJUICE/src/core/toolkits.jl:212
  [6] Solverx
    @ ~/Dartmouth/dJUICE/src/core/toolkits.jl:199 [inlined]
  [7] solutionsequence_nonlinear
    @ ~/Dartmouth/dJUICE/src/core/solutionsequences.jl:53
  [8] Core
    @ ~/Dartmouth/dJUICE/src/core/analyses/stressbalanceanalysis.jl:114
  [9] costfunction
    @ ~/Dartmouth/dJUICE/src/core/solve.jl:70 [inlined]
 [10] diffejulia_costfunction_3853wrap
    @ ~/Dartmouth/dJUICE/src/core/solve.jl:0
 [11] macro expansion
    @ dJUICE ~/.julia/dev/Enzyme/src/compiler.jl:9875 [inlined]
 [12] enzyme_call
    @ dJUICE ~/.julia/dev/Enzyme/src/compiler.jl:9553 [inlined]
 [13] CombinedAdjointThunk
    @ dJUICE ~/.julia/dev/Enzyme/src/compiler.jl:9516 [inlined]
 [14] autodiff
    @ dJUICE ~/.julia/dev/Enzyme/src/Enzyme.jl:213 [inlined]
 [15] autodiff
    @ dJUICE ~/.julia/dev/Enzyme/src/Enzyme.jl:236 [inlined]
 [16] autodiff
codecov[bot] commented 10 months ago

Codecov Report

Merging #402 (99ff84f) into main (4ee3e1e) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   69.05%   69.05%           
=======================================
  Files          26       26           
  Lines        1929     1929           
=======================================
  Hits         1332     1332           
  Misses        597      597           
Files Coverage Δ
ext/LinearSolveEnzymeExt.jl 0.00% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more