SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
241 stars 52 forks source link

Patch SimpleGMRES when `b` is updated #417

Closed avik-pal closed 10 months ago

avik-pal commented 10 months ago

@ChrisRackauckas buildkite doesn't seem to be running on PRs

ChrisRackauckas commented 10 months ago

It only runs on the main package, not on forks

codecov[bot] commented 10 months ago

Codecov Report

Merging #417 (d1509e6) into main (a9b5581) will increase coverage by 0.02%. The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   64.45%   64.48%   +0.02%     
==========================================
  Files          26       26              
  Lines        2068     2078      +10     
==========================================
+ Hits         1333     1340       +7     
- Misses        735      738       +3     
Files Coverage Δ
src/common.jl 90.16% <100.00%> (+0.87%) :arrow_up:
src/simplegmres.jl 86.56% <40.00%> (-1.70%) :arrow_down:

... and 1 file with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

avik-pal commented 10 months ago

@ChrisRackauckas can you make https://buildkite.com/julialang/linearsolve-dot-jl/builds/1504 public? I am not sure what is failing. It passed locally for me

ChrisRackauckas commented 10 months ago

Public.