Open sharanry opened 9 months ago
Attention: 48 lines
in your changes are missing coverage. Please review.
Comparison is base (
9aaf9b3
) 63.96% compared to head (829a914
) 27.07%.
Files | Patch % | Lines |
---|---|---|
ext/LinearSolveForwardDiff.jl | 0.00% | 46 Missing :warning: |
src/common.jl | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Still taking a look at performance improvements.
Figured out the method dispatch ambiguities for all methods Krylov:
See https://github.com/SciML/NonlinearSolve.jl/pull/340. It should be somewhat similar, in that init should build an extended cache.
Note https://github.com/SciML/SciMLBase.jl/issues/558 as a downstream test case.