Closed avik-pal closed 8 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
9787717
) 66.17% compared to head (21559ed
) 66.35%.
Files | Patch % | Lines |
---|---|---|
src/factorization.jl | 85.71% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ChrisRackauckas this is ready
To summarize what this does:
<fact>!
was used, for SArray that is changed to fact
.NormalCholesky
the instance was being created for A
, which should have been for Symmetric(A' * A)
-- unfortunately A * A
pre-1.10 doesn't pass JET opt tests, so testing only 1.10 and above for that.
Checklist
Additional context
Add any other context about the problem here.