Fix NormalCholesky on GPU

avik-pal commented 8 months ago

Checklist

[x] Appropriate tests were added
[x] Any code changes were done in a way that does not break public API
[x] The new code follows the contributor guidelines, in particular the ScioML Style Guide and COLPRAC.

Additional context

Add any other context about the problem here.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (98a377d) 63.56% compared to head (300c4a9) 66.50%. Report is 2 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #443 +/- ## ========================================== + Coverage 63.56% 66.50% +2.94% ========================================== Files 27 27 Lines 2039 2039 ========================================== + Hits 1296 1356 +60 + Misses 743 683 -60 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 8 months ago

Feel free to merge this and the nonlinearsolve thing

SciML / LinearSolve.jl