Closed avik-pal closed 6 months ago
Attention: Patch coverage is 6.66667%
with 42 lines
in your changes are missing coverage. Please review.
Project coverage is 22.96%. Comparing base (
a206054
) to head (06c09a3
).:exclamation: Current head 06c09a3 differs from pull request most recent head 7671369. Consider uploading reports for the commit 7671369 to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/adjoint.jl | 2.32% | 42 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
In the following case the cache stores the correct gradients but they are not propagated to A and b. @ChrisRackauckas any idea how to fix this?
Is this not just an inherent limitation of Zygote with mutation? I would presume we just need to stay away from that and only support solve
with CRC.
Fixes #198, Fixes #322
TODOs:
linsolve !== nothing
case. This is useful if we know that $A^T$ has a structure exploitable by a different solverExample:
In the following case the cache stores the correct gradients but they are not propagated to
A
andb
. @ChrisRackauckas any idea how to fix this?