SciML / LinearSolve.jl

LinearSolve.jl: High-Performance Unified Interface for Linear Solvers in Julia. Easily switch between factorization and Krylov methods, add preconditioners, and all in one interface.
https://docs.sciml.ai/LinearSolve/stable/
Other
245 stars 52 forks source link

various CI improvements #501

Open ArnoStrouwen opened 4 months ago

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.61%. Comparing base (64a8811) to head (7ccafb0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #501 +/- ## ========================================== - Coverage 62.71% 56.61% -6.11% ========================================== Files 29 29 Lines 2229 2222 -7 ========================================== - Hits 1398 1258 -140 - Misses 831 964 +133 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ArnoStrouwen commented 4 months ago

@thazhemadam do you know what the issue is here? https://github.com/SciML/LinearSolve.jl/actions/runs/9061500275/job/24893374532?pr=501#step:8:36 The documentation link in the error message is not even working for me.

ArnoStrouwen commented 4 months ago

I'll need some help fixing this deprecation: https://github.com/SciML/LinearSolve.jl/actions/runs/9061500275/job/24893376530?pr=501#step:6:2073

ChrisRackauckas commented 4 months ago

@fredrikekre "LoadError: mpiexec() is deprecated, use the non-do-block form" do you know the fix here?

fredrikekre commented 4 months ago
diff --git a/test/hypretests.jl b/test/hypretests.jl
index c41079c1..da7e7e3a 100644
--- a/test/hypretests.jl
+++ b/test/hypretests.jl
@@ -168,7 +168,5 @@ test_interface(HYPREAlgorithm(HYPRE.PCG(comm)), Pl = HYPRE.BoomerAMG())

 # Test MPI execution
 mpitestfile = joinpath(@__DIR__, "hypretests_mpi.jl")
-mpiexec() do mpi
-    r = run(ignorestatus(`$(mpi) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
-    @test r.exitcode == 0
-end
+r = run(ignorestatus(`$(mpiexec()) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
+@test r.exitcode == 0