Closed j-fu closed 4 months ago
Attention: Patch coverage is 54.16667%
with 11 lines
in your changes missing coverage. Please review.
Project coverage is 62.72%. Comparing base (
270b56d
) to head (a339509
).
Files | Patch % | Lines |
---|---|---|
ext/LinearSolvePardisoExt.jl | 52.17% | 11 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks like some of the Pardiso tests are failing from this?
Well, they did fail on master before... In fact, now I fixed the transpose flag for MKL Pardiso. Tested also for Panua (formerly project) pardiso ( see Pardiso.jl 0.5.7), which appears to be a bit brittle with iterative solution of complex problem when verbosity is on.
Once this PR is merged I would prepare another one which should allow to choose form both pardiso flavors from the code. Now, just Panua is chosen over MKL if it is installed.
Thanks!
Checklist
Additional context
This tries to fix #497
Pardiso defaults for highly indefinite matrices.
This commit essentially reverts #89 and introduces a new kwarg "cache_analysis" (default
false
) to PardisoJL() which, if true would lead to the behaviour of #89.Also, allow the user to overwrite all iparms modified by the extension besides of 12.
Fixes also a problem found by @chmerdon