Open Qfl3x opened 1 year ago
Attention: 10 lines
in your changes are missing coverage. Please review.
Comparison is base (
6c8b78d
) 69.95% compared to head (9af715e
) 85.81%. Report is 13 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey, rebase and this should pass - thanks!
304
Still has a warning assertion in case all ivs have length 1. Otherwise it will build an interpolation object for the non-"singleton" ivs.
If the model is prompted to give the solution using the interpolator, it will silently ignore the missing ivs and only consider the ivs for which length is > 1.
Performance shouldn't be too big of an issue, though it would've been better to only do the singleton ivs lookup once.
It's all silent, so feel free to add warnings or let me know if you want warnings.