SciML / MethodOfLines.jl

Automatic Finite Difference PDE solving with Julia SciML
https://docs.sciml.ai/MethodOfLines/stable/
MIT License
166 stars 31 forks source link

Get docs compiling #358

Closed cmhyett closed 9 months ago

cmhyett commented 9 months ago

Checklist

Additional context

This is definitely a WIP, just pathfinding to find the offending portions in the docs. Nowhere ready for a review.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0c6b918) 73.50% compared to head (6bfd4f2) 62.02%. Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #358 +/- ## =========================================== - Coverage 73.50% 62.02% -11.49% =========================================== Files 41 41 Lines 1959 1959 =========================================== - Hits 1440 1215 -225 - Misses 519 744 +225 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

cmhyett commented 9 months ago

@xtalax @ChrisRackauckas is there a timeout on how long the docs action can run? I'm now able to build the docs locally, but the action keeps getting cancelled.

I also think we're ready for review. I ballooned the docs/Project.toml file quite a bit, probably the wrong thing to do.

ChrisRackauckas commented 9 months ago

@thazhemadam can we get this one to buildkite too?

thazhemadam commented 9 months ago

@thazhemadam can we get this one to buildkite too?

@ChrisRackauckas does this need to be run on GPU machines? Or will the normal CPU runners suffice?

ChrisRackauckas commented 9 months ago

CPU runners are fine

thazhemadam commented 9 months ago

@thazhemadam can we get this one to buildkite too?

This has been implemented in https://github.com/SciML/MethodOfLines.jl/pull/362.

cmhyett commented 9 months ago

Going to close this PR as I believe it's superseded by #362

ChrisRackauckas commented 9 months ago

No it's complementary.