search

SciML / ModelingToolkit.jl

An acausal modeling framework for automatically parallelized scientific machine learning (SciML) in Julia. A computer algebra system for integrated symbolics for physics-informed machine learning and automated transformations of differential equations
https://mtk.sciml.ai/dev/
Other
1.38k stars 196 forks source link

Test cases in examples/ do not have time dependent solutions #1634

Open Keno opened 2 years ago

Keno commented 2 years ago

The circuit examples in examples/ are static and do not exhibit time-dependent solutions. Ideally, future improvements to structural simplification would eliminate all equations in these models. Since they're used to test various structural simplification code, it would be good to change the examples to something e.g. with an opaque, time-varying voltage source that is not static.

ValentinKaisermayer commented 2 years ago

I think MTK already does that. And both examples in examples are ODEs and do have time dependent solutions. For instance, even though the input voltage is constant the voltage of the capacitor changes over time.

ChrisRackauckas commented 2 years ago

No, that's still an autonomous equation. The issue here is that we should have some non-autonomous equations in the tests.