fix: fix unknowns not present in initialization system in linearization

SciML / ModelingToolkit.jl

An acausal modeling framework for automatically parallelized scientific machine learning (SciML) in Julia. A computer algebra system for integrated symbolics for physics-informed machine learning and automated transformations of differential equations

https://mtk.sciml.ai/dev/

Other

1.38k stars 196 forks source link

fix: fix unknowns not present in initialization system in linearization #2809

Closed AayushSabharwal closed 1 day ago

AayushSabharwal commented 2 weeks ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

ChrisRackauckas commented 2 weeks ago

Test the case I described, x => 2, x ~ y, and y => 2, x ~ y.

AayushSabharwal commented 2 weeks ago

Does this test work? It passed locally, just making sure it's what you're looking for

ChrisRackauckas commented 2 weeks ago

No it needs to be structurally simplified.

AayushSabharwal commented 2 weeks ago

No it needs to be structurally simplified.

structural_simplify happens inside linearization_function, in io_preprocessing.