search

SciML / ModelingToolkit.jl

An acausal modeling framework for automatically parallelized scientific machine learning (SciML) in Julia. A computer algebra system for integrated symbolics for physics-informed machine learning and automated transformations of differential equations
https://mtk.sciml.ai/dev/
Other
1.43k stars 207 forks source link

In MTK v9.42.0 ParentScope not working on expressions #3101

Closed david-hofmann closed 2 weeks ago

david-hofmann commented 2 weeks ago

The latest MTK version does not allow parent scoping on expressions

While this worked in the previous version, applying ParentScope on expressions does cause an error. Probably due to this PR? This causes problems in Neuroblox (https://github.com/Neuroblox/Neuroblox.jl/issues/439)

Minimal Reproducible Example 👇 Related to this documentation example.

using ModelingToolkit
const t = ModelingToolkit.t_nounits
const D = ModelingToolkit.D_nounits

@parameters a b
@variables x(t)

# a is a local variable
b = ParentScope(2b)   # b is a variable that belongs to one level up in the hierarchy

p = [a, b]
eq = [D(x) ~ (a+b)*x]
level0 = System(eq, t, [x], p; name = :level0)
level1 = ODESystem(Equation[], t; name = :level1) ∘ level0

It also breaks when applying ParentScope only to the parameter and compose the expression afterwards b = 2*ParentScope(b)

Error & Stacktrace ⚠️

ERROR: ArgumentError: Cannot find the parent of 2b.
Stacktrace:
  [1] getparent(x::SymbolicUtils.BasicSymbolic{Real}, val::Dict{Any, Any})
    @ Symbolics ~/.julia/packages/Symbolics/rtkf9/src/variable.jl:621
  [2] getparent
    @ ~/.julia/packages/Symbolics/rtkf9/src/variable.jl:613 [inlined]
  [3] _getname(x::SymbolicUtils.BasicSymbolic{Real}, val::Dict{Any, Any})
    @ Symbolics ~/.julia/packages/Symbolics/rtkf9/src/variable.jl:482
  [4] getname (repeats 2 times)
    @ ~/.julia/packages/Symbolics/rtkf9/src/variable.jl:499 [inlined]
  [5] renamespace(sys::ODESystem, x::SymbolicUtils.BasicSymbolic{Real})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1281
  [6] unknowns
    @ ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1517 [inlined]
  [7] parameters
    @ ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1522 [inlined]
  [8] #332
    @ ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1525 [inlined]
  [9] iterate
    @ ./generator.jl:47 [inlined]
 [10] collect_to!
    @ ./array.jl:892 [inlined]
 [11] collect_to_with_first!(dest::Vector{SymbolicUtils.BasicSymbolic{Real}}, v1::SymbolicUtils.BasicSymbolic{Real}, itr::Base.Generator{Vector{SymbolicUtils.BasicSymbolic{Real}}, ModelingToolkit.var"#332#333"{ODESystem}}, st::Int64)
    @ Base ./array.jl:870
 [12] _collect(c::Vector{SymbolicUtils.BasicSymbolic{Real}}, itr::Base.Generator{Vector{SymbolicUtils.BasicSymbolic{Real}}, ModelingToolkit.var"#332#333"{ODESystem}}, ::Base.EltypeUnknown, isz::Base.HasShape{1})
    @ Base ./array.jl:864
 [13] collect_similar
    @ ./array.jl:763 [inlined]
 [14] map
    @ ./abstractarray.jl:3285 [inlined]
 [15] parameters(sys::ODESystem, vs::Vector{SymbolicUtils.BasicSymbolic{Real}})
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1525
 [16] namespace_parameters(sys::ODESystem)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1305
 [17] _broadcast_getindex_evalf
    @ ./broadcast.jl:709 [inlined]
 [18] _broadcast_getindex
    @ ./broadcast.jl:682 [inlined]
 [19] getindex
    @ ./broadcast.jl:636 [inlined]
 [20] copy
    @ ./broadcast.jl:942 [inlined]
 [21] materialize
    @ ./broadcast.jl:903 [inlined]
 [22] parameters(sys::ODESystem)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1424
 [23] show(io::IOContext{Base.TTY}, mime::MIME{Symbol("text/plain")}, sys::ODESystem)
    @ ModelingToolkit ~/.julia/packages/ModelingToolkit/5OzIt/src/systems/abstractsystem.jl:1903
 [24] (::REPL.var"#55#56"{REPL.REPLDisplay{REPL.LineEditREPL}, MIME{Symbol("text/plain")}, Base.RefValue{Any}})(io::Any)
    @ REPL ~/Programs/julia/share/julia/stdlib/v1.10/REPL/src/REPL.jl:273
 [25] with_repl_linfo(f::Any, repl::REPL.LineEditREPL)
    @ REPL ~/Programs/julia/share/julia/stdlib/v1.10/REPL/src/REPL.jl:569
 [26] display(d::REPL.REPLDisplay, mime::MIME{Symbol("text/plain")}, x::Any)
    @ REPL ~/Programs/julia/share/julia/stdlib/v1.10/REPL/src/REPL.jl:259
 [27] display(d::REPL.REPLDisplay, x::Any)
    @ REPL ~/Programs/julia/share/julia/stdlib/v1.10/REPL/src/REPL.jl:278
 [28] display(x::Any)
    @ Base.Multimedia ./multimedia.jl:340
 [29] #invokelatest#2
    @ ./essentials.jl:892 [inlined]
 [30] invokelatest
    @ ./essentials.jl:889 [inlined]
 [31] (::VSCodeServer.var"#69#74"{Bool, Bool, Bool, Module, String, Int64, Int64, String, VSCodeServer.ReplRunCodeRequestParams})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/eval.jl:237
 [32] withpath(f::VSCodeServer.var"#69#74"{Bool, Bool, Bool, Module, String, Int64, Int64, String, VSCodeServer.ReplRunCodeRequestParams}, path::String)
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/repl.jl:276
 [33] (::VSCodeServer.var"#68#73"{Bool, Bool, Bool, Module, String, Int64, Int64, String, VSCodeServer.ReplRunCodeRequestParams})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/eval.jl:179
 [34] hideprompt(f::VSCodeServer.var"#68#73"{Bool, Bool, Bool, Module, String, Int64, Int64, String, VSCodeServer.ReplRunCodeRequestParams})
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/repl.jl:38
 [35] (::VSCodeServer.var"#67#72"{Bool, Bool, Bool, Module, String, Int64, Int64, String, VSCodeServer.ReplRunCodeRequestParams})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/eval.jl:150
 [36] with_logstate(f::Function, logstate::Any)
    @ Base.CoreLogging ./logging.jl:515
 [37] with_logger
    @ ./logging.jl:627 [inlined]
 [38] (::VSCodeServer.var"#66#71"{VSCodeServer.ReplRunCodeRequestParams})()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/eval.jl:263
 [39] #invokelatest#2
    @ ./essentials.jl:892 [inlined]
 [40] invokelatest(::Any)
    @ Base ./essentials.jl:889
 [41] (::VSCodeServer.var"#64#65")()
    @ VSCodeServer ~/.vscode/extensions/julialang.language-julia-1.124.2/scripts/packages/VSCodeServer/src/eval.jl:34

Environment (please complete the following information):

Project Neuroblox v0.5.0
Status `~/Projects/neuroblox/codes/Neuroblox.jl/Project.toml`
  [7d9f7c33] Accessors v0.1.38
  [336ed68f] CSV v0.10.14
  [082447d4] ChainRules v1.71.0
  [861a8166] Combinatorics v1.0.2
  [717857b8] DSP v0.7.10
  [a93c6f00] DataFrames v1.7.0
  [31c24e10] Distributions v0.25.112
  [d4d017d3] ExponentialUtilities v1.26.1
  [f6369f11] ForwardDiff v0.10.36
  [bcd5d0fe] GraphDynamics v0.1.3
  [86223c79] Graphs v1.12.0
  [a98d9a8b] Interpolations v0.15.1
  [2ab3a3ac] LogExpFunctions v0.3.28
  [626554b9] MetaGraphs v0.7.2
  [961ee093] ModelingToolkit v9.42.0
  [16a59e39] ModelingToolkitStandardLibrary v2.15.0
  [46d2c3a1] MuladdMacro v0.2.4
  [bac558e1] OrderedCollections v1.6.3
⌃ [18e31ff7] Peaks v0.4.4
  [731186ca] RecursiveArrayTools v3.27.0
  [189a3867] Reexport v1.2.2
  [0bca4576] SciMLBase v2.55.0
  [2913bbd2] StatsBase v0.34.3
  [789caeaf] StochasticDiffEq v6.69.1
  [0c5d862f] Symbolics v6.13.1
  [c751599d] ToeplitzMatrices v0.8.4
  [37e2e46d] LinearAlgebra
  [9a3f8284] Random
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [8dfed614] Test
Status `~/Projects/neuroblox/codes/Neuroblox.jl/Manifest.toml`
  [47edcb42] ADTypes v1.9.0
  [621f4979] AbstractFFTs v1.5.0
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.38
  [79e6a3ab] Adapt v4.0.4
  [66dad0bd] AliasTables v1.1.3
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.16.0
  [4c555306] ArrayLayouts v1.10.3
  [13072b0f] AxisAlgorithms v1.1.0
  [198e06fe] BangBang v0.4.3
  [e2ed5e7c] Bijections v0.1.9
  [62783981] BitTwiddlingConvenienceFunctions v0.1.6
  [8e7c35d0] BlockArrays v1.1.1
  [2a0fbf3d] CPUSummary v0.2.6
  [00ebfdb7] CSTParser v3.4.3
  [336ed68f] CSV v0.10.14
  [082447d4] ChainRules v1.71.0
  [d360d2e6] ChainRulesCore v1.25.0
  [ae650224] ChunkSplitters v3.1.0
  [fb6a15b2] CloseOpenIntervals v0.1.13
  [944b1d66] CodecZlib v0.7.6
  [861a8166] Combinatorics v1.0.2
  [a80b9123] CommonMark v0.8.15
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.1
  [f70d9fcc] CommonWorldInvalidations v1.0.0
  [34da2185] Compat v4.16.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.8
  [adafc99b] CpuId v0.3.1
  [a8cc5b0e] Crayons v4.1.1
  [717857b8] DSP v0.7.10
  [9a962f9c] DataAPI v1.16.0
  [a93c6f00] DataFrames v1.7.0
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [2b5f629d] DiffEqBase v6.156.1
  [459566f4] DiffEqCallbacks v4.0.0
  [77a26b50] DiffEqNoiseProcess v5.23.0
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [a0c0ee7d] DifferentiationInterface v0.6.6
  [8d63f2c5] DispatchDoctor v0.4.15
  [b4f34e82] Distances v0.10.11
  [31c24e10] Distributions v0.25.112
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.14
  [7c1d4256] DynamicPolynomials v0.6.0
  [06fc5a27] DynamicQuantities v1.1.0
  [4e289a0a] EnumX v1.0.4
  [f151be2c] EnzymeCore v0.8.4
  [d4d017d3] ExponentialUtilities v1.26.1
  [e2ba6199] ExprTools v0.1.10
⌅ [6b7a57c9] Expronicon v0.8.5
  [7a1cc6ca] FFTW v1.8.0
  [7034ab61] FastBroadcast v0.3.5
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.4
  [5789e2e9] FileIO v1.16.3
  [48062228] FilePathsBase v0.9.22
  [1a297f60] FillArrays v1.13.0
  [64ca27bc] FindFirstFunctions v1.4.1
  [6a86dc24] FiniteDiff v2.25.0
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.36
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.4.12
  [46192b85] GPUArraysCore v0.1.6
  [c145ed77] GenericSchur v0.5.4
  [c27321d9] Glob v1.3.1
  [bcd5d0fe] GraphDynamics v0.1.3
  [86223c79] Graphs v1.12.0
  [3e5b6fbb] HostCPUFeatures v0.1.17
  [34004b35] HypergeometricFunctions v0.3.24
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.5
  [22cec73e] InitialValues v0.3.1
  [842dd82b] InlineStrings v1.4.2
  [18e54dd8] IntegerMathUtils v0.1.2
  [a98d9a8b] Interpolations v0.15.1
  [8197267c] IntervalSets v0.7.10
  [3587e190] InverseFunctions v0.1.17
  [41ab1584] InvertedIndices v1.3.0
  [92d709cd] IrrationalConstants v0.2.2
  [c8e1da08] IterTools v1.10.0
  [82899510] IteratorInterfaceExtensions v1.0.0
⌅ [033835bb] JLD2 v0.4.53
  [692b3bcd] JLLWrappers v1.6.0
  [98e50ef6] JuliaFormatter v1.0.61
  [ccbc3e58] JumpProcesses v9.13.7
  [ef3ab10e] KLU v0.6.0
  [ba0b0d4f] Krylov v0.9.6
  [b964fa9f] LaTeXStrings v1.3.1
⌅ [984bce1d] LambertW v0.4.6
  [23fbe1c1] Latexify v0.16.5
  [10f19ff3] LayoutPointers v0.1.17
  [5078a376] LazyArrays v2.2.1
  [2d8b4e74] LevyArea v1.0.0
  [87fe0de2] LineSearch v0.1.3
  [d3d80556] LineSearches v7.3.0
  [7ed4a6bd] LinearSolve v2.35.0
  [2ab3a3ac] LogExpFunctions v0.3.28
  [bdcacae8] LoopVectorization v0.12.171
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [d125e4d3] ManualMemory v0.1.8
  [bb5d69b7] MaybeInplace v0.1.4
  [626554b9] MetaGraphs v0.7.2
  [e1d29d7a] Missings v1.2.0
  [961ee093] ModelingToolkit v9.42.0
  [16a59e39] ModelingToolkitStandardLibrary v2.15.0
  [46d2c3a1] MuladdMacro v0.2.4
  [102ac46a] MultivariatePolynomials v0.5.6
  [d8a4904e] MutableArithmetics v1.5.0
  [d41bc354] NLSolversBase v7.8.3
  [2774e3e8] NLsolve v4.5.1
  [77ba4419] NaNMath v1.0.2
  [8913a72c] NonlinearSolve v3.15.1
  [6fe1bfb0] OffsetArrays v1.14.1
  [67456a42] OhMyThreads v0.7.0
  [429524aa] Optim v1.9.4
  [bac558e1] OrderedCollections v1.6.3
  [1dea7af3] OrdinaryDiffEq v6.89.0
  [89bda076] OrdinaryDiffEqAdamsBashforthMoulton v1.1.0
  [6ad6398a] OrdinaryDiffEqBDF v1.1.2
  [bbf590c4] OrdinaryDiffEqCore v1.6.0
  [50262376] OrdinaryDiffEqDefault v1.1.0
  [4302a76b] OrdinaryDiffEqDifferentiation v1.1.0
  [9286f039] OrdinaryDiffEqExplicitRK v1.1.0
  [e0540318] OrdinaryDiffEqExponentialRK v1.1.0
  [becaefa8] OrdinaryDiffEqExtrapolation v1.1.0
  [5960d6e9] OrdinaryDiffEqFIRK v1.1.1
  [101fe9f7] OrdinaryDiffEqFeagin v1.1.0
  [d3585ca7] OrdinaryDiffEqFunctionMap v1.1.1
  [d28bc4f8] OrdinaryDiffEqHighOrderRK v1.1.0
  [9f002381] OrdinaryDiffEqIMEXMultistep v1.1.0
  [521117fe] OrdinaryDiffEqLinear v1.1.0
  [1344f307] OrdinaryDiffEqLowOrderRK v1.2.0
  [b0944070] OrdinaryDiffEqLowStorageRK v1.2.1
  [127b3ac7] OrdinaryDiffEqNonlinearSolve v1.2.1
  [c9986a66] OrdinaryDiffEqNordsieck v1.1.0
  [5dd0a6cf] OrdinaryDiffEqPDIRK v1.1.0
  [5b33eab2] OrdinaryDiffEqPRK v1.1.0
  [04162be5] OrdinaryDiffEqQPRK v1.1.0
  [af6ede74] OrdinaryDiffEqRKN v1.1.0
  [43230ef6] OrdinaryDiffEqRosenbrock v1.2.0
  [2d112036] OrdinaryDiffEqSDIRK v1.1.0
  [669c94d9] OrdinaryDiffEqSSPRK v1.2.0
  [e3e12d00] OrdinaryDiffEqStabilizedIRK v1.1.0
  [358294b1] OrdinaryDiffEqStabilizedRK v1.1.0
  [fa646aed] OrdinaryDiffEqSymplecticRK v1.1.0
  [b1df2697] OrdinaryDiffEqTsit5 v1.1.0
  [79d7bb75] OrdinaryDiffEqVerner v1.1.1
  [90014a1f] PDMats v0.11.31
  [65ce6f38] PackageExtensionCompat v1.0.2
  [d96e819e] Parameters v0.12.3
  [69de0a69] Parsers v2.8.1
⌃ [18e31ff7] Peaks v0.4.4
  [e409e4f3] PoissonRandom v0.4.4
  [f517fe37] Polyester v0.7.16
  [1d0040c9] PolyesterWeave v0.2.2
  [f27b6e38] Polynomials v4.0.11
  [2dfb63ee] PooledArrays v1.4.3
  [85a6dd25] PositiveFactorizations v0.2.4
  [d236fae5] PreallocationTools v0.4.24
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [08abe8d2] PrettyTables v2.4.0
  [27ebfcd6] Primes v0.5.6
  [43287f4e] PtrArrays v1.2.1
  [1fd47b50] QuadGK v2.11.1
  [74087812] Random123 v1.7.0
  [e6cf234a] RandomNumbers v1.6.0
  [c84ed2f1] Ratios v0.4.5
  [c1ae055f] RealDot v0.1.0
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.27.0
  [f2c3362d] RecursiveFactorization v0.2.23
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [ae5879a3] ResettableStacks v1.1.1
  [79098fc4] Rmath v0.8.0
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.43
  [0bca4576] SciMLBase v2.55.0
  [19f34311] SciMLJacobianOperators v0.1.0
  [c0aeaf25] SciMLOperators v0.3.10
  [53ae85a6] SciMLStructures v1.5.0
  [91c51154] SentinelArrays v1.4.5
  [efcf1570] Setfield v1.1.1
  [727e6d20] SimpleNonlinearSolve v1.12.3
  [699a6c99] SimpleTraits v0.9.4
  [ce78b400] SimpleUnPack v1.1.0
  [a2af1166] SortingAlgorithms v1.2.1
  [9f842d2f] SparseConnectivityTracer v0.6.6
  [47a9eef4] SparseDiffTools v2.22.0
  [dc90abb0] SparseInverseSubset v0.1.2
  [0a514795] SparseMatrixColorings v0.4.6
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.4.0
  [91464d47] StableTasks v0.1.5
  [aedffcd0] Static v1.1.1
  [0d7ed370] StaticArrayInterface v1.8.0
  [90137ffa] StaticArrays v1.9.7
  [1e83bf80] StaticArraysCore v1.4.3
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.2
  [789caeaf] StochasticDiffEq v6.69.1
  [7792a7ef] StrideArraysCore v0.5.7
  [892a3eda] StringManipulation v0.4.0
  [09ab397b] StructArrays v0.6.18
  [2efcf032] SymbolicIndexingInterface v0.3.31
  [19f23fe9] SymbolicLimits v0.2.2
  [d1185830] SymbolicUtils v3.7.1
  [0c5d862f] Symbolics v6.13.1
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.12.0
  [ed4db957] TaskLocalValues v0.1.2
  [8ea1fca8] TermInterface v2.0.0
  [1c621080] TestItems v1.0.0
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.24
  [c751599d] ToeplitzMatrices v0.8.4
  [0796e94c] Tokenize v0.5.29
  [3bb67fe8] TranscodingStreams v0.11.3
  [d5829a12] TriangularSolve v0.2.1
  [410a4b4d] Tricks v0.1.9
  [781d530d] TruncatedStacktraces v1.4.0
  [5c2747f8] URIs v1.5.1
  [3a884ed6] UnPack v1.0.2
  [1986cc42] Unitful v1.21.0
  [a7c27f48] Unityper v0.1.6
  [3d5dd08c] VectorizationBase v0.21.70
  [19fa3120] VertexSafeGraphs v0.2.0
  [ea10d353] WeakRefStrings v1.4.2
  [efce3f68] WoodburyMatrices v1.0.0
  [76eceee3] WorkerUtilities v1.6.1
  [f5851436] FFTW_jll v3.3.10+1
  [1d5cc7b8] IntelOpenMP_jll v2024.2.1+0
  [856f044c] MKL_jll v2024.2.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.5.1+0
  [1317d2d5] oneTBB_jll v2021.12.0+0
  [0dad84c5] ArgTools v1.1.1
  [56f22d72] Artifacts
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [4af54fe1] LazyArtifacts
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.10.0
  [de0858da] Printf
  [3fa0cd96] REPL
  [9a3f8284] Random
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization
  [1a1011a3] SharedArrays
  [6462fe0b] Sockets
  [2f01184e] SparseArrays v1.10.0
  [10745b16] Statistics v1.10.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test
  [cf7118a7] UUIDs
  [4ec0a83e] Unicode
  [e66e0078] CompilerSupportLibraries_jll v1.1.1+0
  [deac9b47] LibCURL_jll v8.4.0+0
  [e37daf67] LibGit2_jll v1.6.4+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.2+1
  [14a3606d] MozillaCACerts_jll v2023.1.10
  [4536629a] OpenBLAS_jll v0.3.23+4
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.2.1+1
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.8.0+1
  [8e850ede] nghttp2_jll v1.52.0+1
  [3f19e933] p7zip_jll v17.4.0+2
Julia Version 1.10.4
Commit 48d4fd48430 (2024-06-04 10:41 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 8 × 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, tigerlake)
Threads: 1 default, 0 interactive, 1 GC (on 8 virtual cores)
Environment:
  JULIA_EDITOR = code
  JULIA_NUM_THREADS =
AayushSabharwal commented 2 weeks ago

Why are you making 2b a parameter of the system, though? Also you're applying ParentScope, but the parent system (level1) doesn't actually have that variable (b) which seems wrong.

This works:

@parameters a b
_b = ParentScope(2b)
eq = [D(x) ~ (a+_b)*x]
p = [a, b]
level0 = System(eq, t, [x], [a]; name = :level0)
level1 = ODESystem(Equation[], t, [], [b]; name = :level1) ∘ level0

Which is what ParentScope means.

If I'm missing the point here, please correct me.

david-hofmann commented 2 weeks ago

I see, thank you! This makes sense and seems actually cleaner. How I coded it used to work in the past version, I suppose that is because the parameters were inferred from the equations, rather than passed to System explicitly? The way we coded it up currently in Neuroblox relies on that parameter inference, so please help me fully understand the new implementation.

Let's say I remove the parameters in System, it can still infer them from the equation but only the one that is not scoped:

using ModelingToolkit
const t = ModelingToolkit.t_nounits
const D = ModelingToolkit.D_nounits

@parameters a b
@variables x(t)

_b = ParentScope(2b)
eq = [D(x) ~ (a+_b)*x]
p = [a, b]
level0 = System(eq, t; name = :level0)
level1 = ODESystem(Equation[], t; name = :level1) ∘ level0

gives

Model level0 with 1 equations
Unknowns (1):
  x(t)
Parameters (1):
  a

Model level1 with 1 equations
Unknowns (1):
  level0₊x(t)
Parameters (1):
  level0₊a

Is this intended behavior? It seems somehow inconsistent, why would I not infer also b? Why just not show it? It makes sense to not show it on level0 but on level1 it could be included, no? That would solve our issue.

AayushSabharwal commented 2 weeks ago

Hmm. Yeah I guess we could infer it in level1. I'm fairly certain this working before was more of a happy accident that also ended up breaking other systems.

david-hofmann commented 1 week ago

Thanks so much for #3112 it all works now!