fix: fix unnecessary `oneunit` call in `get_unit`

SciML / ModelingToolkit.jl

An acausal modeling framework for automatically parallelized scientific machine learning (SciML) in Julia. A computer algebra system for integrated symbolics for physics-informed machine learning and automated transformations of differential equations

https://mtk.sciml.ai/dev/

Other

1.43k stars 209 forks source link

fix: fix unnecessary `oneunit` call in `get_unit` #3108

Open AayushSabharwal opened 1 month ago

AayushSabharwal commented 1 month ago

Close #3017

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

Add any other context about the problem here.

isaacsas commented 1 month ago

Note that this causes this simple unit test to fail now:

https://github.com/SciML/ModelingToolkit.jl/actions/runs/11250561770/job/31279691694?pr=3108#step:6:925

which is indicative that units in registered functions still have an issue that this was masking.

ChrisRackauckas commented 3 weeks ago

I think we need a way to register unit arithmetic on a registered function.