SciML / ModelingToolkitNeuralNets.jl

Symbolic-Numeric Universal Differential Equations for Automating Scientific Machine Learning (SciML)
MIT License
23 stars 1 forks source link

Fix NaN in gradients #8

Closed SebastianM-C closed 6 months ago

SebastianM-C commented 6 months ago

The initial conditions for the UDE are the same as the reference solution, leading to taking the derivative of sqrt at 0, which is NaN. Changing the loss function to squared l2loss fixes this.

Checklist

Additional context

Fixes #6

codecov[bot] commented 6 months ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

ChrisRackauckas commented 6 months ago

We should remove nightly from the tests, I don't know how that got on there.

SebastianM-C commented 6 months ago

I think PkgTemplates added it, I'll drop that.

SebastianM-C commented 6 months ago

Other than that the CI failures are unrelated to this PR.