SciML / ModelingToolkitStandardLibrary.jl

A standard library of components to model the world and beyond
https://docs.sciml.ai/ModelingToolkitStandardLibrary/stable/
MIT License
112 stars 36 forks source link

Switch defaults for guesses for some components #292

Closed SebastianM-C closed 4 months ago

SebastianM-C commented 4 months ago

Checklist

Additional context

With MTK@v9 the defaults act as equations duing initialization, which can lead to overconstrained systems that can't be solved in some cases.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.29%. Comparing base (37faf7b) to head (ab38d19). Report is 18 commits behind head on main.

:exclamation: Current head ab38d19 differs from pull request most recent head 39f5098. Consider uploading reports for the commit 39f5098 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #292 +/- ## ========================================== - Coverage 61.53% 54.29% -7.24% ========================================== Files 46 46 Lines 1448 1641 +193 ========================================== Hits 891 891 - Misses 557 750 +193 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.