SciML / NeuralPDE.jl

Physics-Informed Neural Networks (PINN) Solvers of (Partial) Differential Equations for Scientific Machine Learning (SciML) accelerated simulation
https://docs.sciml.ai/NeuralPDE/stable/
Other
992 stars 200 forks source link

PhysicsInformedNN Documentation Incorrect on Where Parameters Estimation Params Go #679

Open allen-adastra opened 1 year ago

allen-adastra commented 1 year ago

The docs claim that when doing parameter estimation problems w/ additional loss functions, the params should go to the end of $\theta$ image

By copying the Lorenz attractor example, I was able to show that actually the parameters are going into p. I've put the following print statements: image

And we can see that we initialize the params to 1.0: image

And we get the following printout image

Should the docs be updated, or should this bug be fixed s.t. the parameter estimation params go into \theta?

ChrisRackauckas commented 1 year ago

Yes, the docs should be updated.