better BPINN formulation, improvements to include dataset domain points

SciML / NeuralPDE.jl

Physics-Informed Neural Networks (PINN) Solvers of (Partial) Differential Equations for Scientific Machine Learning (SciML) accelerated simulation

https://docs.sciml.ai/NeuralPDE/stable/

Other

923 stars 196 forks source link

better BPINN formulation, improvements to include dataset domain points #842

Open AstitvaAggarwal opened 3 months ago

AstitvaAggarwal commented 3 months ago

Checklist

[ ] Appropriate tests were added
[ ] Any code changes were done in a way that does not break public API
[ ] All documentation related to code changes were updated
[ ] The new code follows the contributor guidelines, in particular the SciML Style Guide and COLPRAC.
[ ] Any new documentation only uses public API

Additional context

will add docs and more tests separately

AstitvaAggarwal commented 3 months ago

@Vaibhavdixit02 @ChrisRackauckas this is the new PR, closed the previous one due to large number of merge conflicts after the repo was recently majorly formatted. Discussions from previous PR: https://github.com/SciML/NeuralPDE.jl/pull/799

ChrisRackauckas commented 2 months ago

There's a lot of random stuff together in here. Break this apart into simple one thing PRs and lets merge those.

Vaibhavdixit02 commented 1 month ago

@AstitvaAggarwal do you think you can make this into multiple smaller PRs as Chri suggested above?

AstitvaAggarwal commented 1 month ago

Yes, will do

AstitvaAggarwal commented 1 month ago

@ChrisRackauckas @Vaibhavdixit02 I've seperated the code into two PRs. one for the better ode solver and this for the PDE solver.