SciML / NeuralPDE.jl

Physics-Informed Neural Networks (PINN) Solvers of (Partial) Differential Equations for Scientific Machine Learning (SciML) accelerated simulation
https://docs.sciml.ai/NeuralPDE/stable/
Other
996 stars 200 forks source link

Making the package more maintainable #900

Open avik-pal opened 1 month ago

avik-pal commented 1 month ago

I did an initial round of cleanup in https://github.com/SciML/NeuralPDE.jl/pull/882, but there's a lot of unwanted code that should be purged, and most of the handling should be forwarded to Lux.

P.S. Just because I am opening this issue doesn't mean I am taking it upon me to do this :sweat:

ChrisRackauckas commented 1 month ago

Agreed with all of these.

sathvikbhagavan commented 1 month ago

I can help out a bit.

For 1 - GPU Support for NNODE, users should provide the model, initial conditions and parameters in gpu arrays in order to not error? Also, initially I thought GPU works with NNODE now, I wanted to confirm it - I was working on a https://github.com/SciML/NeuralPDE.jl/pull/866 which implemented a custom broadcast, is it still needed?

For 2 - Will that fix using autodiff with NNODE?

avik-pal commented 1 month ago
  1. Correct. Does GPU already not work with NNODE? I thought I fixed it
  2. Yes that's the main goal