SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
239 stars 42 forks source link

Including jvp for radius update schemes #172

Closed yash2798 closed 1 year ago

ChrisRackauckas commented 1 year ago

Needs to add the dependency.

codecov[bot] commented 1 year ago

Codecov Report

Merging #172 (50f266d) into master (c9ffc07) will increase coverage by 6.80%. The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master     #172      +/-   ##
==========================================
+ Coverage   85.08%   91.88%   +6.80%     
==========================================
  Files           7        7              
  Lines         590      604      +14     
==========================================
+ Hits          502      555      +53     
+ Misses         88       49      -39     
Impacted Files Coverage Δ
src/jacobian.jl 87.17% <ø> (ø)
src/trustRegion.jl 94.81% <89.47%> (+16.02%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

yash2798 commented 1 year ago

The issue is resolved, if there's nothing else, i think we can merge this pr.

ChrisRackauckas commented 1 year ago

Test failed, looks like a tolerance issue.

yash2798 commented 1 year ago

works now