Implementing the final bastin's scheme for trust region radius

[codecov[bot]]

Codecov Report

Merging #188 (6ab670e) into master (8d009b9) will decrease coverage by 79.56%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master     #188       +/-   ##
===========================================
- Coverage   93.77%   14.22%   -79.56%     
===========================================
  Files           7        7               
  Lines         675      689       +14     
===========================================
- Hits          633       98      -535     
- Misses         42      591      +549     

Impacted Files	Coverage Δ
src/trustRegion.jl	0.00% <0.00%> (-97.63%)	:arrow_down:

... and 6 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[yash2798]

@ChrisRackauckas for the convergence tests, I am thinking to test the value $ ||u_{k+1} - u_k $ to be smaller than a given tolerance and if it is, the test passes. Is this fine?

Also some time back, you pointed out to involve NLSolve.jl in the convergence tests. what do you exactly mean by that?

[ChrisRackauckas]

yes

Also some time back, you pointed out to involve NLSolve.jl in the convergence tests. what do you exactly mean by that?

https://github.com/SciML/SciMLNLSolve.jl

[yash2798]

@ChrisRackauckas This is ready to be merged, the issues are resolved and tests pass. i'll continue adding convergence tests in a separate pr.

[ChrisRackauckas]

resolve conflicts

[ChrisRackauckas]

looks like it just needs a formatter run

[yash2798]

Do you mean just run the JuliaFormatter as given here

[yash2798]

@ChrisRackauckas I did format and resolved conflicts but still some CI checks fail. why is that happening?

[yash2798]

This pr got messed up a little so i am closing it. Here is the new one