SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
239 stars 42 forks source link

Add support for JFNK #201

Closed avik-pal closed 1 year ago

codecov[bot] commented 1 year ago

Codecov Report

Merging #201 (c006772) into master (e93fc58) will increase coverage by 0.67%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   93.75%   94.42%   +0.67%     
==========================================
  Files           7        7              
  Lines         720      699      -21     
==========================================
- Hits          675      660      -15     
+ Misses         45       39       -6     
Files Changed Coverage Δ
src/NonlinearSolve.jl 100.00% <ø> (ø)
src/levenberg.jl 95.71% <ø> (-0.37%) :arrow_down:
src/raphson.jl 97.10% <ø> (-0.52%) :arrow_down:
src/trustRegion.jl 96.81% <ø> (-0.14%) :arrow_down:
src/utils.jl 81.42% <ø> (+7.14%) :arrow_up:
src/jacobian.jl 90.81% <100.00%> (+3.63%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

avik-pal commented 1 year ago

Ok definitely broke something :sweat:

avik-pal commented 1 year ago

@ChrisRackauckas can you rerun the integration test, it somehow got cancelled https://github.com/SciML/NonlinearSolve.jl/actions/runs/5941975798/job/16113962425?pr=201#step:6:1070

ChrisRackauckas commented 1 year ago

I think it's fine.