search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

Don't change the default termination condition #264

Closed avik-pal closed 10 months ago

avik-pal commented 10 months ago

NLSolveDefault is from SimpleNonlinearSolve which works fine work simple usecases but for general problems it is almost always a terrible choice

codecov[bot] commented 10 months ago

Codecov Report

Merging #264 (c428bd9) into master (8fe131a) will increase coverage by 0.34%. The diff coverage is 69.23%.

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   92.74%   93.08%   +0.34%     
==========================================
  Files          19       19              
  Lines        1806     1794      -12     
==========================================
- Hits         1675     1670       -5     
+ Misses        131      124       -7
Files Coverage Δ
src/broyden.jl 100.00% <100.00%> (+3.40%) :arrow_up:
src/dfsane.jl 100.00% <100.00%> (ø)
src/klement.jl 86.60% <100.00%> (ø)
src/levenberg.jl 98.86% <100.00%> (ø)
src/pseudotransient.jl 100.00% <100.00%> (ø)
src/raphson.jl 100.00% <100.00%> (ø)
src/trustRegion.jl 99.37% <100.00%> (ø)
src/gaussnewton.jl 78.31% <66.66%> (ø)
src/utils.jl 82.63% <36.36%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more