search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

Removing Allocation for Inexact Jacobian #266

Closed yonatanwesen closed 10 months ago

yonatanwesen commented 10 months ago

This PR make sure that we don't allocate memory when computing the inexact Jacobian for PT methods. Instead, we just overwrite the jacobian that is already allocated. @avik-pal @ChrisRackauckas

codecov[bot] commented 10 months ago

Codecov Report

Merging #266 (abaf747) into master (3565824) will decrease coverage by 52.64%. The diff coverage is 73.33%.

@@             Coverage Diff             @@
##           master     #266       +/-   ##
===========================================
- Coverage   93.04%   40.40%   -52.64%     
===========================================
  Files          19       19               
  Lines        1796     1767       -29     
===========================================
- Hits         1671      714      -957     
- Misses        125     1053      +928
Files Coverage Δ
src/NonlinearSolve.jl 100.00% <100.00%> (ø)
src/pseudotransient.jl 66.29% <71.42%> (-33.71%) :arrow_down:

... and 16 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more