SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

Gauss Newton with Line Search #268

Closed avik-pal closed 10 months ago

avik-pal commented 10 months ago

TODOs

codecov[bot] commented 10 months ago

Codecov Report

Merging #268 (77be3a2) into master (b8d43a3) will increase coverage by 45.16%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #268       +/-   ##
===========================================
+ Coverage   48.41%   93.58%   +45.16%     
===========================================
  Files          19       19               
  Lines        1801     1807        +6     
===========================================
+ Hits          872     1691      +819     
+ Misses        929      116      -813     
Files Coverage Δ
src/gaussnewton.jl 77.27% <100.00%> (+14.91%) :arrow_up:
src/linesearch.jl 88.05% <100.00%> (+82.79%) :arrow_up:
src/raphson.jl 100.00% <ø> (+26.98%) :arrow_up:
src/utils.jl 85.54% <ø> (+33.22%) :arrow_up:

... and 14 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

vpuri3 commented 10 months ago

Any reason to not use LineSearches.jl?

avik-pal commented 10 months ago

It is using LineSearches internally

avik-pal commented 10 months ago

This is done. just need the previous PRs to be merged

vpuri3 commented 10 months ago

would it be possible to pass an initial guess for alpha and line search? example? InitialStatic(), InitialPrevious(), etc...

avik-pal commented 10 months ago

would it be possible to pass an initial guess for alpha and line search? example? InitialStatic(), InitialPrevious(), etc...

Not currently. I have no clue how that API currently works.