search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

Replace `.*(Number, Diagonal)` with `*(Number, Diagonal)` #270

Closed vpuri3 closed 10 months ago

vpuri3 commented 10 months ago

The result with / without broadcasting here is the same. Removing the broadcast here would avoid https://github.com/JuliaGPU/CUDA.jl/issues/2140. Further, when cache.DtD.diag isa ComponentVector that CUDA bug leads to scalar indexing error on GPU.

codecov[bot] commented 10 months ago

Codecov Report

Merging #270 (be9ce44) into master (b07360f) will decrease coverage by 0.29%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   93.49%   93.20%   -0.29%     
==========================================
  Files          19       19              
  Lines        1782     1781       -1     
==========================================
- Hits         1666     1660       -6     
- Misses        116      121       +5
Files Coverage Δ
src/levenberg.jl 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

vpuri3 commented 10 months ago

are the failures related to this PR @avik-pal ?

avik-pal commented 10 months ago

Rebase this should have been fixed