search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

test PT on 23 test problems #280

Closed yonatanwesen closed 10 months ago

yonatanwesen commented 10 months ago

I forgot to add PT to 23 test problems. This PR fixes that issue

codecov[bot] commented 10 months ago

Codecov Report

Merging #280 (28c2137) into master (c6c875f) will increase coverage by 44.73%. Report is 4 commits behind head on master. The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #280       +/-   ##
===========================================
+ Coverage   48.45%   93.19%   +44.73%     
===========================================
  Files          19       19               
  Lines        1814     1821        +7     
===========================================
+ Hits          879     1697      +818     
+ Misses        935      124      -811

see 18 files with indirect coverage changes

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

avik-pal commented 10 months ago

Run the formatter

ChrisRackauckas commented 10 months ago

https://github.com/SciML/NonlinearSolve.jl/actions/runs/6776687678/job/18418713412?pr=280#step:6:598 test failure, is it one of the introduced ones?

yonatanwesen commented 10 months ago

https://github.com/SciML/NonlinearSolve.jl/actions/runs/6776687678/job/18418713412?pr=280#step:6:598 test failure, is it one of the introduced ones?

No. I don't see any failures in the tests I introduced