SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
226 stars 40 forks source link

Reduce unnecessary allocations and reuse code #297

Closed avik-pal closed 9 months ago

avik-pal commented 9 months ago

Fixes #291

Checklist

Additional context

Add any other context about the problem here.

avik-pal commented 9 months ago

Tests should pass once the linked PRs are merged

codecov[bot] commented 9 months ago

Codecov Report

Attention: 62 lines in your changes are missing coverage. Please review.

Comparison is base (657c549) 93.07% compared to head (3b52a5a) 87.40%. Report is 2 commits behind head on master.

Files Patch % Lines
src/utils.jl 82.90% 20 Missing :warning:
src/levenberg.jl 91.48% 8 Missing :warning:
src/trace.jl 58.82% 7 Missing :warning:
src/gaussnewton.jl 81.81% 6 Missing :warning:
src/jacobian.jl 92.95% 5 Missing :warning:
src/lbroyden.jl 92.18% 5 Missing :warning:
src/trustRegion.jl 95.79% 5 Missing :warning:
src/NonlinearSolve.jl 89.47% 4 Missing :warning:
src/pseudotransient.jl 94.11% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #297 +/- ## ========================================== - Coverage 93.07% 87.40% -5.68% ========================================== Files 21 21 Lines 2065 1683 -382 ========================================== - Hits 1922 1471 -451 - Misses 143 212 +69 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 9 months ago

The docs build needs to be fixed though