search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
221 stars 39 forks source link

Fix storing the trace #304

Closed avik-pal closed 7 months ago

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b14b20) 87.40% compared to head (4d605b9) 88.01%.

Files Patch % Lines
src/trace.jl 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #304 +/- ## ========================================== + Coverage 87.40% 88.01% +0.61% ========================================== Files 21 21 Lines 1683 1669 -14 ========================================== - Hits 1471 1469 -2 + Misses 212 200 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 7 months ago

The lintcheck will be fixed once https://github.com/SciML/SimpleNonlinearSolve.jl/pull/107 is in. But bumping SimpleNonlinearSolve compact requires a breaking change which is a part of https://github.com/SciML/NonlinearSolve.jl/pull/302

avik-pal commented 7 months ago

This is ready