search

SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
221 stars 39 forks source link

Allow for Custom Functions for Updating Alpha #336

Closed yonatanwesen closed 6 months ago

yonatanwesen commented 7 months ago

Rather than hardcoding how we update alpha, we now allow the user to provide a function that specifies the schema for updating alpha. The default is still the same(i.e. we still use the switch evolution relaxation method). I have added the documentation and the appropriate tests. We have decided to have another PR for robust PT. #326 had too many commits when rebasing.

@avik-pal

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d723578) 88.79% compared to head (efbe82d) 88.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #336 +/- ## ========================================== + Coverage 88.79% 88.81% +0.01% ========================================== Files 24 24 Lines 1972 1975 +3 ========================================== + Hits 1751 1754 +3 Misses 221 221 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

avik-pal commented 6 months ago

https://github.com/SciML/NonlinearSolve.jl/pull/345 has a more principled implementation for this.