SciML / NonlinearSolve.jl

High-performance and differentiation-enabled nonlinear solvers (Newton methods), bracketed rootfinding (bisection, Falsi), with sparsity and Newton-Krylov support.
https://docs.sciml.ai/NonlinearSolve/stable/
MIT License
234 stars 40 forks source link

Standardize the Extension Algorithms #341

Closed avik-pal closed 9 months ago

avik-pal commented 9 months ago

Checklist

codecov[bot] commented 9 months ago

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (fa16796) 88.04% compared to head (bfaf014) 87.47%.

Files Patch % Lines
src/function_wrappers.jl 72.34% 26 Missing :warning:
ext/NonlinearSolveSIAMFANLEquationsExt.jl 72.91% 13 Missing :warning:
src/extension_algs.jl 76.19% 5 Missing :warning:
ext/NonlinearSolveNLsolveExt.jl 92.30% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #341 +/- ## ========================================== - Coverage 88.04% 87.47% -0.57% ========================================== Files 27 28 +1 Lines 2174 2172 -2 ========================================== - Hits 1914 1900 -14 - Misses 260 272 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ChrisRackauckas commented 9 months ago

Are the 23 test problem failures known?

ChrisRackauckas commented 9 months ago

I presume that's what was fixed in the problem library, so it should have passed?